[go_router] Fix a typo in the ShellRoute docstring #3378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an extraneous "that" and an unnecessary comma.
chunhtai
added
override: no versioning needed
johnpryan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 3378, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
johnpryan
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 3378, due to - The status or check suite repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
Hmm, I'm wondering why we can't submit this? This shouldn't need version change, so we added the "override: no versioning needed" label, but it's saying that "the change to this package could not be verified to be exempt from version changes according to repository policy" |
Contributor
|
forgot to rerun the check after applying the label, rerunning |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[go_router] Fix a typo in the ShellRoute docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an extraneous "that" and an unnecessary comma.
This is just a simple typo fix for the docstring comment above the ShellRoute class.
Assuming I am correct that this is a typo, I think it makes the documentation a little
more difficult to read.
There is no issue open to track this, but I can create one if it's really necessary.
I'm going to check the box in the pre-launch checklist anyways 🙈
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).