Skip to content

Add additional Windows template icons #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbracken merged 1 commit into from
May 14, 2021
Merged

Add additional Windows template icons #357

cbracken merged 1 commit into from
May 14, 2021

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 14, 2021

Adds additional icons for Windows targets.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 14, 2021
@cbracken
Copy link
Member Author

cbracken commented May 14, 2021 •
edited
Loading

This needs #353 to land first. This patch includes both that commit and the new one. Once @stuartmorgan is able to land the revert, I'll rebase to head, leaving just the new icons.

@cbracken cbracken requested a review from stuartmorgan-g May 14, 2021 19:35
jonahwilliams
jonahwilliams approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan-g
stuartmorgan-g approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken
Add additional Windows template icons
9ff10ff 
Updates to version 3.0.1
christopherfujino
christopherfujino approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit c52dc90 into flutter:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@clarkezone clarkezone Awaiting requested review from clarkezone

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: flutter_template_images waiting for tree to go green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbracken @stuartmorgan-g @christopherfujino @jonahwilliams