Skip to content

Conversation

@filiph
Copy link
Contributor

@filiph filiph commented May 28, 2021

Relands #295 after it was reverted with #353.

There is a proposal to add a new Flutter app template to the flutter CLI. This new app template lives alongside the current counter template, it does not replace it. The team has made the following request on the related PR:

We need to find a way to not duplicate the existing platform files. We occasionally have to update these, and having 2 copies of everything is going to increase the chances that we accidentally get out of sync somewhere.

This PR moves assets common to both apps into an app_shared directory and introduces a new list_detail_app folder to support images unique to the new template.

Related Issues:

See more at #295.

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
    • no code change here, just new files
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label May 28, 2021
@filiph filiph changed the title [WIP] [flutter_template_images] Support the new skeleton app template [flutter_template_images] Support the new skeleton app template Jun 7, 2021
@filiph
Copy link
Contributor Author

filiph commented Jun 7, 2021

Hi, this is ready for review. I have LGTM for the corresponding change over at flutter/flutter#83530.

I have tested locally to what extent I could.

@filiph filiph requested a review from stuartmorgan-g June 7, 2021 20:50
@stuartmorgan-g
Copy link
Collaborator

Hi, this is ready for review. I have LGTM for the corresponding change over at flutter/flutter#83530.

The PR doesn't have any actual approvals, and it looks like there is active discussion there right now about create not actually working correctly with that template.

The previous version had initial LGTMs too, but was never actually finished despite that. I will review and land this when that PR is approved by everyone who you are expecting a review from, and it is ready to land, other than the tests.

@filiph
Copy link
Contributor Author

filiph commented Jun 7, 2021

That's fair. I do have LGTMs from csells and goderbauer on that CL (they're comments), but you're right that Hixie and HansMuller have only commented. I should have checked. Sorry about that.

I'll get the missing approvals.

@filiph
Copy link
Contributor Author

filiph commented Jun 28, 2021

Hi, flutter/flutter#83530 is now LGTM'd (Hixie & Jonah in UI + comment; Chris & Michael in comment text only). The change passes locally — at least the test I was able to run on my device.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filiph filiph merged commit e528db7 into flutter:master Jun 28, 2021
stuartmorgan-g pushed a commit that referenced this pull request Aug 27, 2025
)

Bumps [path_provider](https://github.com/flutter/packages/tree/main/packages/path_provider) from 2.0.12 to 2.0.13.
- [Release notes](https://github.com/flutter/packages/releases)
- [Commits](https://github.com/flutter/packages/commits/path_provider-v2.0.13/packages/path_provider)

---
updated-dependencies:
- dependency-name: path_provider
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants