-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[flutter_template_images] Support the new skeleton app template #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, this is ready for review. I have LGTM for the corresponding change over at flutter/flutter#83530. I have tested locally to what extent I could. |
The PR doesn't have any actual approvals, and it looks like there is active discussion there right now about The previous version had initial LGTMs too, but was never actually finished despite that. I will review and land this when that PR is approved by everyone who you are expecting a review from, and it is ready to land, other than the tests. |
|
That's fair. I do have LGTMs from csells and goderbauer on that CL (they're comments), but you're right that Hixie and HansMuller have only commented. I should have checked. Sorry about that. I'll get the missing approvals. |
|
Hi, flutter/flutter#83530 is now LGTM'd (Hixie & Jonah in UI + comment; Chris & Michael in comment text only). The change passes locally — at least the test I was able to run on my device. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) Bumps [path_provider](https://github.com/flutter/packages/tree/main/packages/path_provider) from 2.0.12 to 2.0.13. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/path_provider-v2.0.13/packages/path_provider) --- updated-dependencies: - dependency-name: path_provider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Relands #295 after it was reverted with #353.
See more at #295.
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy].CHANGELOG.mdto add a description of the change.///).