Skip to content

[Pigeon] enum ios unittest #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaaclarke merged 2 commits into from
Jun 14, 2021
Merged

[Pigeon] enum ios unittest #376

gaaclarke merged 2 commits into from
Jun 14, 2021

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 8, 2021 •
edited
Loading

addendum to: #375
depends on: #373

cc @GaryQian

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@gaaclarke gaaclarke force-pushed the pigeon_enum_ios_unittest branch from 72b85eb to 84edb9b Compare June 14, 2021 18:33
@gaaclarke gaaclarke force-pushed the pigeon_enum_ios_unittest branch from 84edb9b to aea7e78 Compare June 14, 2021 18:37
@gaaclarke gaaclarke marked this pull request as ready for review June 14, 2021 18:39
@gaaclarke
Copy link
Member Author

gaaclarke commented Jun 14, 2021

(one sec, I forgot to upload pigeons/enum.dart and subsequently deleted it)

GaryQian
GaryQian approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@GaryQian
Copy link
Contributor

GaryQian commented Jun 14, 2021

Oh i assumed it was already in pigeons. Guess not.

@gaaclarke
Copy link
Member Author

gaaclarke commented Jun 14, 2021

Added it now if you want to double check it.

@GaryQian
Copy link
Contributor

GaryQian commented Jun 14, 2021

Yep, still lgtm.

@gaaclarke gaaclarke merged commit 5bd986b into flutter:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @GaryQian