[flutter_markdown] Unable to use MarkdownElementBuilder to act those tags without children. #3952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
Please add tests that exercise the error condition that this PR fixes
MeandNi
changed the title
MeandNi
changed the title
Contributor
Author
done |
Contributor
|
Looking at CI, looks like there are some issues: |
Contributor
|
Cool! Can you now please update the version and add some notes to the changedoc about this change? It won't be released to the world without bumping the version =) |
domesticmouse
approved these changes
May 11, 2023
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
PTAL @stuartmorgan
stuartmorgan-g
requested changes
May 11, 2023
Closed
2 tasks
stuartmorgan-g
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
…t those tags without children. (flutter/packages#3952)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
flutter/packages@c85111c...95bb793 2023-05-31 ditman@gmail.com [google_maps] Prepares packages to endorse web. (flutter/packages#4064) 2023-05-30 ditman@gmail.com [google_sign_in] Clarifies canAccessScopes docs. (flutter/packages#4092) 2023-05-30 35989475+MeandNi@users.noreply.github.com [flutter_markdown] Unable to use MarkdownElementBuilder to act those tags without children. (flutter/packages#3952) 2023-05-30 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.5 to 1.5.6 in /packages/local_auth/local_auth_android/android (flutter/packages#3553) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 12, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#126402
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.