Skip to content

[pigeon] Update example README #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 14 commits into from
Sep 20, 2021
Merged

[pigeon] Update example README #406

fluttergithubbot merged 14 commits into from
Sep 20, 2021

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jul 12, 2021

fixes flutter/flutter#86228

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 12, 2021
stuartmorgan-g
stuartmorgan-g requested changes Jul 12, 2021
View reviewed changes
packages/pigeon/CHANGELOG.md Outdated

* [front-end] Added a more explicit error if generic fields are used.
* [front-end] Added a more explicit error for static fields.
* [front-end] Added more errors for incorrect usage of Pigeon (previously they were just ignored).
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add things below NEXT. Everything in NEXT will be in this release.

packages/pigeon/CHANGELOG.md Outdated
* [front-end] Added a more explicit error for static fields.
* [front-end] Added more errors for incorrect usage of Pigeon (previously they were just ignored).

## 0.3.1
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.3.0+1

packages/pigeon/example/README.md Outdated
This example gives an overview of how to use Pigeon to call into the
host-platform from Flutter.

First, follow the [steps](https://pub.dev/packages/pigeon#usage) to setup pigeon for iOS and Android.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "setup" is a noun; the verb is "set up"

@stuartmorgan-g stuartmorgan-g requested a review from gaaclarke July 12, 2021 18:41
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jul 12, 2021

Adding @gaaclarke to review the actual docs change since he's the primary maintainer.

gaaclarke
gaaclarke reviewed Jul 19, 2021
View reviewed changes
packages/pigeon/example/README.md Outdated
Comment on lines 8 to 9
First, follow the [steps](https://pub.dev/packages/pigeon#usage) to set up pigeon for iOS and Android.

Copy link
Member

@gaaclarke gaaclarke Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that this is helpful because those steps aren't required to read or use the example. If we thinking adding that link is a good idea it would be better to say something like:

For instructions to set up your own Pigeon usage see these steps.

Copy link
Member Author

@TahaTesser TahaTesser Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, added the changes

@TahaTesser TahaTesser requested a review from gaaclarke July 19, 2021 17:33
gaaclarke
gaaclarke approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Aug 24, 2021

@TahaTesser Are you planning on fixing the version mismatch so that this can land? (You'll also need to merge in master to get the fix for the local_tests error.)

@TahaTesser
Copy link
Member Author

TahaTesser commented Aug 24, 2021

@stuartmorgan
Thanks, I just updated the branch, even 0.3.0+1 is the same in pubspec, CHANGELOG, and `lib/generator_tools.dart.
It says mismatch, I am not sure why

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Aug 25, 2021

@stuartmorgan
Thanks, I just updated the branch, even 0.3.0+1 is the same in pubspec, CHANGELOG, and `lib/generator_tools.dart.
It says mismatch, I am not sure why

The summary is wrong; the real error is the one just above about NEXT.

@TahaTesser
Copy link
Member Author

TahaTesser commented Aug 31, 2021 •
edited
Loading

I noticed #447 removed NEXT and bumps to package to 1.0.0 and I read somewhere for 1.0.0, we're supposed to bump the version instead of adding +1, if I remember correctly

Made changes to be merged after #447 is merged

@TahaTesser
Merge branch 'master' of github.com:flutter/packages into update_exam…
eb522ef 
…ple_instructions

# Conflicts:
#	packages/pigeon/CHANGELOG.md
#	packages/pigeon/lib/generator_tools.dart
#	packages/pigeon/pubspec.yaml
@TahaTesser
updated
24f0f94
@TahaTesser
update version
7cb8c1b
@TahaTesser
Copy link
Member Author

TahaTesser commented Sep 20, 2021

Hi @stuartmorgan
This could probably get merge now, appreciate the patience

stuartmorgan-g
stuartmorgan-g approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 0bab590 into flutter:master Sep 20, 2021
@TahaTesser TahaTesser deleted the update_example_instructions branch September 20, 2021 18:14
stuartmorgan-g pushed a commit that referenced this pull request Aug 27, 2025
@material-robot @guidezpl
Update google_fontss fonts (#406)
e01fc45 
* [google_fonts] update fonts

  - Removed `Arima Madurai`
  - Removed `Fredoka One`
  - Removed `Gentium Book Basic`
  - Removed `Kantumruy`
  - Removed `Merienda One`
  - Removed `Noto Sans N Ko`
  - Removed `Noto Serif Nyiakeng Puachue Hmong`
  - Added `Alkatra`
  - Added `Anuphan`
  - Added `Braah One`
  - Added `Bruno Ace`
  - Added `Bruno Ace SC`
  - Added `Carlito`
  - Added `Castoro Titling`
  - Added `Chivo Mono`
  - Added `Climate Crisis`
  - Added `Comme`
  - Added `Darumadrop One`
  - Added `Delicious Handrawn`
  - Added `Foldit`
  - Added `Gajraj One`
  - Added `Gloock`
  - Added `Golos Text`
  - Added `Hanken Grotesk`
  - Added `Instrument Sans`
  - Added `Instrument Serif`
  - Added `Konkhmer Sleokchher`
  - Added `Labrada`
  - Added `Martian Mono`
  - Added `Mynerve`
  - Added `Noto Sans NKo`
  - Added `Noto Sans Nag Mundari`
  - Added `Noto Sans Nandinagari`
  - Added `Noto Sans SignWriting`
  - Added `Noto Sans Tangsa`
  - Added `Noto Serif NP Hmong`
  - Added `Noto Serif Toto`
  - Added `Padyakke Expanded One`
  - Added `Pathway Extreme`
  - Added `Phudu`
  - Added `Poltawski Nowy`
  - Added `Rubik 80s Fade`
  - Added `Rubik Gemstones`
  - Added `Rubik Pixels`
  - Added `Rubik Spray Paint`
  - Added `Rubik Storm`
  - Added `Rubik Vinyl`
  - Added `Schibsted Grotesk`
  - Added `Shantell Sans`
  - Added `Sigmar`
  - Added `Sofia Sans`
  - Added `Sofia Sans Condensed`
  - Added `Sofia Sans Extra Condensed`
  - Added `Sofia Sans Semi Condensed`
  - Added `Solitreo`
  - Added `Tilt Neon`
  - Added `Tilt Prism`
  - Added `Tilt Warp`
  - Added `Unbounded`
  - Added `Vina Sans`
  - Added `Wix Madefor Display`
  - Added `Wix Madefor Text`
  - Added `Ysabeau`

* x

* bump version

* format

* add formatting to Google Fonts GitHub workflow

* Update google_fonts_update.yml

* add back cider bumping and releasing from google_fonts workflow

* fix API rate limit for pull request labeling

* x

---------

Co-authored-by: Pierre-Louis Guidez <plg@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

cla: yes p: pigeon waiting for tree to go green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pigeon] - Dart Error: error: import of dart:mirrors is not supported in the current Dart runtime

4 participants

@TahaTesser @stuartmorgan-g @gaaclarke @fluttergithubbot