Skip to content

Conversation

@codingiran
Copy link

@codingiran codingiran commented Oct 20, 2023

In objective-c, NSNumber should always convert to Bool manually by type conversion, otherwise nonnull NSNumber will convert to "YES" automatically

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@codingiran codingiran requested a review from vashworth as a code owner October 20, 2023 06:19
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Oct 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vashworth
Copy link
Contributor

@codingiran Thank you for the contribution! Before I can review this PR, can you please complete the steps in the Pre-launch Checklist (which I added back to the PR description). This includes signing the CLA and adding tests.

@codingiran codingiran changed the title image_picker_ios requestFullMetadata property should convert from NSNumber to boolValue [image_picker_ios] requestFullMetadata property should convert from NSNumber to boolValue Oct 21, 2023
@codingiran codingiran closed this Oct 21, 2023
@codingiran
Copy link
Author

@codingiran Thank you for the contribution! Before I can review this PR, can you please complete the steps in the Pre-launch Checklist (which I added back to the PR description). This includes signing the CLA and adding tests.

Remove this issue and open a new one, please check
#5194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants