[various] Disambiguate TestDefaultBinaryMessengerBinding #6009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
LouiseHsu,
bparrishMines,
camsim99,
cbracken,
chunhtai,
gmackall,
hellohuanlin,
reidbaker and
tarrinneal
as code owners
github-actions
bot
added
p: go_router
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
platform-android
platform-ios
platform-linux
platform-macos
platform-windows
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
labels
reidbaker
approved these changes
Jan 29, 2024
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 30, 2024
flutter/packages@516648a...25abb5d 2024-01-30 tessertaha@gmail.com [rfw] Add `OverflowBar` widget and Update `ButtonBar` widget implementation (flutter/packages#5807) 2024-01-30 stuartmorgan@google.com [ci] Reduce tasks slightly (flutter/packages#6011) 2024-01-29 stuartmorgan@google.com Clarify issue requirement (flutter/packages#6010) 2024-01-29 stuartmorgan@google.com [various] Disambiguate TestDefaultBinaryMessengerBinding (flutter/packages#6009) 2024-01-29 engine-flutter-autoroll@skia.org Manual roll Flutter from a8efa77 to 2f6fdf2 (23 revisions) (flutter/packages#6008) 2024-01-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.1 to 3.23.2 (flutter/packages#5987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "ambiguate" method that was used to allow compatibility with both stable and master during the transition of
TestDefaultBinaryMessengerBinding.instancefrom a nullable return to a non-nullable return, now that all versions we analyze are sufficiently new to have the non-nullable version.Part of flutter/flutter#111841