Skip to content

Conversation

@hyeokeunmun
Copy link

When picking a GIF image with maxWidth/maxHeight on Android, there's an issue where the animation of the file gets removed.
It seems necessary to add proper resizing logic for GIF files, but for now, I've added straightforward logic to return the original file if it's a GIF file.

Fixes #144546 related #34134

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hyeokeunmun hyeokeunmun requested a review from gmackall as a code owner March 5, 2024 19:35
@google-cla
Copy link

google-cla bot commented Mar 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@hyeokeunmun hyeokeunmun force-pushed the image-picker-android-not-resize-gif branch from be4da4f to 5c754e5 Compare March 5, 2024 20:31
@stuartmorgan-g
Copy link
Collaborator

Thanks for the contribution, but this is not a change we would accept. Please see discussion here and here, as well as later discussion in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker][Android]: Support Animated Gif with resizing option.

2 participants