Remove unnecessary breaks in default clauses of switch statements #7462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
requested review from
Hixie,
bparrishMines,
camsim99,
cbracken,
chunhtai,
gmackall,
hellohuanlin,
jmagman and
matanlurey
as code owners
github-actions
bot
added
p: rfw
matanlurey
approved these changes
Aug 21, 2024
Member
Author
|
@stuartmorgan Does this require incrementing any package version numbers? Or should I add the override labels? |
Collaborator
|
Usually we err on the side of releasing anything that changes code, but this is very clearly a no-op so it's fine to override. |
stuartmorgan-g
added
override: no versioning needed
Collaborator
|
Override changelog and version: While technically a code change, this is a no-op behaviorally. |
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2024
flutter/packages@4e5d47e...c5d03ee 2024-08-21 34871572+gmackall@users.noreply.github.com [many] Remove dependency on `kotlin-bom` (flutter/packages#7088) 2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@4e5d47e...c5d03ee 2024-08-21 34871572+gmackall@users.noreply.github.com [many] Remove dependency on `kotlin-bom` (flutter/packages#7088) 2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/packages#7462) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dart.googlesource.com/sdk.git/+/045d26bc74209f5acc6466669f89686344e83de2