[google_maps_flutter_android] Convert PlatformTileOverlay to Pigeon
#7467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Aug 23, 2024
| @@ -1,5 +1,9 @@ | |||
| ## 2.14.2 | |||
Collaborator
There was a problem hiding this comment.
Looks like a bad merge from main here.
| TileOverlay tileOverlay) { | ||
| // This cast is not ideal, but the Java code already assumes this format. | ||
| // See the TODOs at the top of this file and on the 'json' field in | ||
| // messages.dart. |
Collaborator
There was a problem hiding this comment.
This whole comment is now obsolete, and should be removed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2024
flutter/packages@d862279...2a0f254 2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager` (flutter/packages#7437) 2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523) 2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511) 2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369) 2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513) 2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515) 2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421) 2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500) 2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498) 2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487) 2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands #6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497) 2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands #6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989) 2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467) 2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext � (flutter/packages#7337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@d862279...2a0f254 2024-08-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for remaining methods of the Android native `AdsManager` (flutter/packages#7437) 2024-08-28 brackenavaron@gmail.com [shared_preferences] Fix typo in changelog (flutter/packages#7523) 2024-08-27 matanlurey@users.noreply.github.com Remove matan from codeowners (flutter/packages#7511) 2024-08-27 tarrinneal@gmail.com [shared_preferences] Add test to enforce mutable lists (flutter/packages#7369) 2024-08-27 magder@google.com [google_sign_in_ios] Fix "callee requires a non-null parameter" analyzer warning (flutter/packages#7513) 2024-08-27 louisehsu@google.com [in_app_purchase_storekit] Allows 'localizedDescription' to be nullable to handle occasional nulls in Storekit objects (flutter/packages#7515) 2024-08-27 31859944+LongCatIsLooong@users.noreply.github.com Cupertino icons golden tests (flutter/packages#7421) 2024-08-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.10 to 2.0.20 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7500) 2024-08-26 zezohassam@gmail.com [video_player] Updates minimum supported SDK (flutter/packages#7498) 2024-08-26 paulberry@google.com [url_launcher] Ignore new `unreachable_switch_default` warning. (flutter/packages#7487) 2024-08-26 linxunfeng@yeah.net Revert "[video_player] Relands flutter#6456: Uses SurfaceProducer, this time with setCallback for suspend/resume lifecycles" (flutter/packages#7497) 2024-08-24 matanlurey@users.noreply.github.com [video_player] Relands flutter#6456: Uses `SurfaceProducer`, this time with `setCallback` for suspend/resume lifecycles. (flutter/packages#6989) 2024-08-23 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Convert `PlatformTileOverlay` to Pigeon (flutter/packages#7467) 2024-08-23 47866232+chunhtai@users.noreply.github.com [go_router] Fixes issue so that the parseRouteInformationWithContext � (flutter/packages#7337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
PlatformTileOverlayfrom using a JSON implementation to a structured typesafe one.Addresses flutter/flutter#152927, which concerns
PlatformTileOverlayas well asPlatformTile. However, as it appearsPlatformTileis already typesafe, this should resolve the issue.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.