-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router] Secured empty matches in canPop #8557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If current configuration matches is empty, canPop throws exceptions instead of quit properly
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it! The fix lgtm, can you add a test to make sure we don't regress this change? it is also our policy to only accept change with a test.
While you at it, can you also bump the pubspec.yaml and changelog?
Sure thing. |
|
@chunhtai are we good to go ? |
|
@ditman maybe you can help? |
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hannah-hyj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@c44c228...01d3d5c 2025-02-27 engine-flutter-autoroll@skia.org Manual roll Flutter from 043b719 to 1659206 (19 revisions) (flutter/packages#8728) 2025-02-27 stuartmorgan@google.com Manual roll Flutter from 911aa75 to 043b719 (flutter/packages#8693) 2025-02-26 magder@google.com Dependabot to update major and minor versions of test dependencies, ignore patch (flutter/packages#8712) 2025-02-26 reidbaker@google.com [local_auth] Update to use flutter.targetSdkVersion (flutter/packages#8695) 2025-02-26 57854043+CaoGiaHieu-dev@users.noreply.github.com [go_router_builder]: Handle invaild params (flutter/packages#8405) 2025-02-26 stuartmorgan@google.com [pigeon] Timestamp test steps in CI (flutter/packages#8716) 2025-02-26 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix 90°-off preview rotation (flutter/packages#8629) 2025-02-26 108667553+aprzedecki@users.noreply.github.com [go_router] Secured empty matches in canPop (flutter/packages#8557) 2025-02-26 reidbaker@google.com [tool] Update targetsdk version to 35 from 32 (flutter/packages#8694) 2025-02-26 stuartmorgan@google.com [various] Bump androidx.test:core to 1.4.0 (flutter/packages#8710) 2025-02-26 stuartmorgan@google.com [camera] Disable flaky tests (flutter/packages#8708) 2025-02-26 mdebbar@google.com [url_launcher][web] Prevent browser from navigating when followLink isn't called (flutter/packages#8675) 2025-02-26 stuartmorgan@google.com [various] Remove plugin-level `integration_test` dependencies (flutter/packages#8711) 2025-02-26 stuartmorgan@google.com [ci] Lengthen custom tests timeout (flutter/packages#8715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
If current configuration matches is empty, canPop throws exceptions instead of quit properly ``` StateError: Bad state: No element App 0x1086b3e80 List.last (growable_array.dart:349) App 0x108996274 GoRouterDelegate.canPop (delegate.dart:84) App 0x1089961bc GoRouter.canPop (router.dart:330) App 0x10899615c BuildContextExtension|get#_shouldPop (build_context_extensions.dart:40) ``` - if there are no elements, poping page throws an error
If current configuration matches is empty, canPop throws exceptions instead of quit properly ``` StateError: Bad state: No element App 0x1086b3e80 List.last (growable_array.dart:349) App 0x108996274 GoRouterDelegate.canPop (delegate.dart:84) App 0x1089961bc GoRouter.canPop (router.dart:330) App 0x10899615c BuildContextExtension|get#_shouldPop (build_context_extensions.dart:40) ``` - if there are no elements, poping page throws an error
If current configuration matches is empty, canPop throws exceptions instead of quit properly
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.