[camera_android_camerax] Fix incorrectly rotated captured photos #9498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
changed the title
ash2moon
approved these changes
Jun 26, 2025
gmackall
approved these changes
Jun 26, 2025
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2025
flutter/packages@4841ada...471bfd3 2025-06-30 stuartmorgan@google.com [google_maps_flutter] Remove legacy renderer tests (flutter/packages#9517) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the all-github-actions group (flutter/packages#9524) 2025-06-29 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix incorrectly rotated captured photos (flutter/packages#9498) 2025-06-29 stuartmorgan@google.com [in_app_purchase] Annotate deprecation in test (flutter/packages#9473) 2025-06-29 malo.allee@gmail.com [video_player] Add poster attribute for html video tag in video_player_platform_interface (flutter/packages#8979) 2025-06-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6fba244 to fcf2c11 (6 revisions) (flutter/packages#9502) 2025-06-29 muhatashim@google.com Skip test to unblock packages (flutter/packages#9516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@4841ada...471bfd3 2025-06-30 stuartmorgan@google.com [google_maps_flutter] Remove legacy renderer tests (flutter/packages#9517) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the all-github-actions group (flutter/packages#9524) 2025-06-29 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix incorrectly rotated captured photos (flutter/packages#9498) 2025-06-29 stuartmorgan@google.com [in_app_purchase] Annotate deprecation in test (flutter/packages#9473) 2025-06-29 malo.allee@gmail.com [video_player] Add poster attribute for html video tag in video_player_platform_interface (flutter/packages#8979) 2025-06-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6fba244 to fcf2c11 (6 revisions) (flutter/packages#9502) 2025-06-29 muhatashim@google.com Skip test to unblock packages (flutter/packages#9516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…tter#9498) Changes the target rotation of captured images to match that of the default display at the time of capture. This ensures that the photo's orientation is upright. This in turn fixes the rotation of the thumbnail previewing a captured photo (the thumbnail was never rotated incorrectly, just the image itself). Fixes flutter/flutter#169876. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@4841ada...471bfd3 2025-06-30 stuartmorgan@google.com [google_maps_flutter] Remove legacy renderer tests (flutter/packages#9517) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.3.4 to 1.4.0 in the all-github-actions group (flutter/packages#9524) 2025-06-29 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Fix incorrectly rotated captured photos (flutter/packages#9498) 2025-06-29 stuartmorgan@google.com [in_app_purchase] Annotate deprecation in test (flutter/packages#9473) 2025-06-29 malo.allee@gmail.com [video_player] Add poster attribute for html video tag in video_player_platform_interface (flutter/packages#8979) 2025-06-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6fba244 to fcf2c11 (6 revisions) (flutter/packages#9502) 2025-06-29 muhatashim@google.com Skip test to unblock packages (flutter/packages#9516) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the target rotation of captured images to match that of the default display at the time of capture. This ensures that the photo's orientation is upright. This in turn fixes the rotation of the thumbnail previewing a captured photo (the thumbnail was never rotated incorrectly, just the image itself).
Fixes flutter/flutter#169876.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3