Skip to content

Conversation

@Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Feb 28, 2022

Before After

This PR adds new tests, reaching code paths not previously covered as pointed by a coverage report.
Closes #99286

No CHANGELOG change: because it doesn't affect the package's users.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g stuartmorgan-g requested a review from chunhtai March 1, 2022 21:14
@chunhtai
Copy link
Contributor

chunhtai commented Mar 4, 2022

Also I have a massive lint update to the package #1017

I would prefer to land it before this pr to avoid adding more tech debt on top of go_router

@Ascenio Ascenio requested a review from chunhtai March 7, 2022 02:29
@Ascenio Ascenio requested a review from maheshj01 March 8, 2022 12:23
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can you remove the src sub folder? Let's follow the folder structure of other packages. The folder test/ maps to lib/src directly, so you don't need to create a src fold in test folder.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests seemed to be gone?

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from Renzo-Olivares March 10, 2022 00:25
@Ascenio
Copy link
Contributor Author

Ascenio commented Mar 10, 2022

Some tests seemed to be gone?

Technical Difficulties 🤣

@chunhtai chunhtai requested a review from stuartmorgan-g March 17, 2022 16:31
@chunhtai
Copy link
Contributor

@Ascenio it looks like there is a conflict?

@chunhtai
Copy link
Contributor

the build fails

�[36m[0:00] Running for go_router...�[0m
3.0.4 -> 3.0.5
�[31m When bumping the version for release, the NEXT section should be incorporated into the new version's release notes.�[0m

@johnpryan
Copy link
Contributor

I think most of my comments can be addressed as a follow-up. I can file issues if they're out of scope for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] Increase coverage

5 participants