-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router] improve coverage #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also I have a massive lint update to the package #1017 I would prefer to land it before this pr to avoid adding more tech debt on top of go_router |
Because vscode test runner doesn't like it. xD
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Can you remove the src sub folder? Let's follow the folder structure of other packages. The folder test/ maps to lib/src directly, so you don't need to create a src fold in test folder.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests seemed to be gone?
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technical Difficulties 🤣 |
|
@Ascenio it looks like there is a conflict? |
|
the build fails �[36m[0:00] Running for go_router...�[0m |
|
I think most of my comments can be addressed as a follow-up. I can file issues if they're out of scope for this PR. |
This PR adds new tests, reaching code paths not previously covered as pointed by a coverage report.
Closes #99286
No CHANGELOG change: because it doesn't affect the package's users.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.