Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@Yarikk26
Copy link

Workaround for flutter/flutter#19197.
Checked on the video from example project and on my use-cases.

@bparrishMines bparrishMines changed the title video_player plugin: Future already completed fix [video_player] Future already completed fix Feb 22, 2019
@bparrishMines bparrishMines added bugfix submit queue The Flutter team is in the process of landing this PR. labels Feb 22, 2019
rcunning added a commit to rcunning/plugins that referenced this pull request Mar 13, 2019
@cbenhagen
Copy link
Contributor

cbenhagen commented Apr 27, 2019

I don't think this is an appropriate fix as playbackLikelyToKeepUp has nothing to do with being initialized.

Either we make sure to only send the initialized event once from the iOS side. Or we do this in dart:

if (!value.initialized) {
  value = value.copyWith(
    duration: Duration(milliseconds: map['duration']),
    size: Size(map['width']?.toDouble() ?? 0.0,
        map['height']?.toDouble() ?? 0.0),
  );
  initializingCompleter.complete(null);
  _applyLooping();
  _applyVolume();
  _applyPlayPause();
}

@iskakaushik
Copy link
Contributor

This should be addressed in version: 0.10.0+8 by this PR: #1552 please re-open this if it's still an issue. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla: yes submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants