[webview_flutter] Added the ability to activate the zoom (Android) #1235

Dn-a · 2019-02-18T20:56:18Z

I added the ability to enable zooming on Android WebView.
by default it is set to false.

Pop-up zoom control is disabled, dialog is not responding to touch events.
webView.getSettings().setDisplayZoomControls(false);

googlebot · 2019-02-18T20:56:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

Googlers can find more info about SignCLA and this PR by following this link.

Dn-a · 2019-02-18T21:05:06Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
* It's possible we don't have your GitHub username or you're using a different email address on your commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
Corporate signers
* Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google.com/docs/cla/#troubleshoot)).

* The email used to register you as an authorized contributor must be the email used for the Git commit. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).

* The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).
Googlers can find more info about SignCLA and this PR by following this link.

I signed it!

googlebot · 2019-02-18T21:05:08Z

CLAs look good, thanks!

Googlers can find more info about SignCLA and this PR by following this link.

amirh

Thanks for the contribution!

I left a few comments, other than that we will need to:

Add e2e tests in example/test_driver/webview.dart.
Revert the .arb file.

amirh · 2019-03-29T21:29:17Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java


+  private void updateZoomMode(boolean mode) {
+    //webView.getSettings().setLoadWithOverviewMode(true);
+    webView.getSettings().setUseWideViewPort(mode);


Why is this tied to the zoom mode?

When the value is true and the page contains the viewport meta tag, the value of the width specified in the tag is used. If the page does not contain the tag or does not provide a width, then a wide viewport will be used. actually i can remove mode and leave it on true. do you suggest to create another parameter for separate management?

amirh · 2019-03-29T21:29:31Z

.../webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java

  }

+  private void updateZoomMode(boolean mode) {
+    //webView.getSettings().setLoadWithOverviewMode(true);


delete this line

amirh · 2019-03-29T21:31:27Z

packages/webview_flutter/lib/webview_flutter.dart

  final Set<JavascriptChannel> javascriptChannels;
-
+
+  /// Enable/Disable zoom.


Is there a way to do the same on iOS?
If yes we should support that as well, if no the comment should mention that this is a no-op on iOS.

at the moment I have no way to test the ios environment. I will modify the comment in on-op on ios

amirh · 2019-03-29T21:32:21Z

packages/webview_flutter/lib/webview_flutter.dart

-
+
+  /// Enable/Disable zoom.
+  final bool zoom;


nit: I'd suggest calling this zoomEnabled (I can imagine a parameter named zoom being used to set a zoom level)

ok, of course

amirh · 2019-03-29T21:33:01Z

packages/webview_flutter/lib/webview_flutter.dart

-    this.javascriptMode,
-  });
-
+  _WebSettings({this.javascriptMode, this.zoom});


The way this worked has changed a bit, please rebase and use the widget reference.

Dn-a · 2019-03-30T16:42:44Z

@amirh I know it is not the right place but I could not find a solution to this problem flutter_plugin_tools, could you help me?

AkoWu101 · 2019-10-30T07:41:06Z

Any news for this feature? The latest version does not support it

Added the ability to activate the zoom

d0cfbb5

googlebot added the cla: no label Feb 18, 2019

googlebot added cla: yes and removed cla: no labels Feb 18, 2019

Dn-a added 7 commits February 18, 2019 22:24

Added the ability to activate the zoom

619434a

update format

0346929

update format

a87b554

update format

88f417a

update format

060a049

update format

a8e3ca9

update format

a8769eb

bparrishMines changed the title ~~Added the ability to activate the zoom (Android)~~ [webview_flutter] Added the ability to activate the zoom (Android) Feb 22, 2019

bparrishMines added feature bugfix labels Feb 22, 2019

amirh suggested changes Mar 29, 2019

View reviewed changes

Dn-a closed this Apr 7, 2019

Dn-a deleted the zoom_webview branch April 7, 2019 17:55

Dn-a mentioned this pull request Apr 7, 2019

[webview_flutter] Added possibility to activate the zoom webview Android - no-op on IOS (Android) #1459

Closed

		final Set<JavascriptChannel> javascriptChannels;


		/// Enable/Disable zoom.

[webview_flutter] Added the ability to activate the zoom (Android) #1235

[webview_flutter] Added the ability to activate the zoom (Android) #1235

Uh oh!

Conversation

Dn-a commented Feb 18, 2019

Uh oh!

googlebot commented Feb 18, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

Dn-a commented Feb 18, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Feb 18, 2019

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

Dn-a Mar 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirh Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

Dn-a Mar 30, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

Dn-a Mar 30, 2019

Choose a reason for hiding this comment

Uh oh!

amirh Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

Dn-a commented Mar 30, 2019

Uh oh!

AkoWu101 commented Oct 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dn-a Mar 30, 2019 •

edited

Loading