This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Send success result for AlarmService.initialized method call
#1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
approved these changes
Mar 22, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Make sure to update the changelog and bump the version before submitting.
Contributor
Author
I have some other changes for this plugin that should be going in shortly, so I'll hold off bumping the version for now and include this change in that release, particularly since this change shouldn't actually change any behavior for users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.