Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented May 3, 2019

Fixes flutter/flutter#32042

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This is not a breaking change but I'm updating the version to 1.0 since the plugin is mature enough for that.

@collinjackson collinjackson requested a review from mklim May 3, 2019 21:48
@collinjackson collinjackson changed the title Release path_provider as 1.0 and add tests [path_provider] Release as 1.0 and add integration tests May 3, 2019
@mklim
Copy link
Contributor

mklim commented May 3, 2019

Not seeing any new integration tests here?

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@collinjackson
Copy link
Contributor Author

Not seeing any new integration tests here?

Checked in the missing folder, PTAL

@collinjackson collinjackson merged commit 1b3413a into flutter:master May 3, 2019
@collinjackson collinjackson deleted the pathprovider branch May 3, 2019 22:13
@collinjackson
Copy link
Contributor Author

Note that there's a follow-up to this change in #1566

julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Add testing for path_provider
* Add @collinjackson to codeowners
* Release as 1.0
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

promote path_provider plugin to 1.0

3 participants