This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Enable camera plugin to compile with earlier android apis with custom AndroidManifest settings #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Contributor
|
I can confirm that it works, I just get not sure where it come from :/ |
mklim
reviewed
May 14, 2019
packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| @SuppressWarnings("ConstantConditions") |
Contributor
There was a problem hiding this comment.
Why is this being suppressed?
Contributor
Author
There was a problem hiding this comment.
The casting of Exception to RuntimeException. From my understanding of Java, CameraAccessException is the only checked exception that will come from these methods. Otherwise it should be a RuntimeException.
Contributor
In general it sounds related to flutter/flutter#27254? |
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
…th custom AndroidManifest settings (flutter#1598)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable camera plugin to compile with earlier android sdks with custom AndroidManifest settings.
Catching
CameraAccessExceptions in theonMethodCallprevented compilation on <21. This separates handling them into another method.Related Issues
Original PR: #1482
Fixes flutter/flutter#30854
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?