Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix camera memory leak on IOS #1745

Merged
mklim merged 6 commits into from
Jul 22, 2019
Merged

[camera] Fix camera memory leak on IOS #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ac5f45
Fix camera memory leak on IOS
greggor01 Jun 14, 2019
6fcedfb
increased build number
greggor01 Jun 14, 2019
2b293c7
increased version number
greggor01 Jun 14, 2019
bab35dc
Merge branch 'master' into camera-memory-leak-IOS
greggor01 Jul 18, 2019
800e6a5
Release the camera event channel in the onCancel event
greggor01 Jul 18, 2019
1c34284
Update pubspec.yaml
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.5.2+2

* Fix memory leak related to not unregistering stream handler in FlutterEventChannel when disposing camera.

## 0.5.2+1

* Fix bug that prevented video recording with audio.
Expand Down
2 changes: 2 additions & 0 deletions packages/camera/ios/Classes/CameraPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,8 @@ - (CVPixelBufferRef)copyPixelBuffer {

- (FlutterError *_Nullable)onCancelWithArguments:(id _Nullable)arguments {
_eventSink = nil;
// need to unregister stream handler when disposing the camera
[_eventChannel setStreamHandler:nil];
return nil;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.5.2+1
publish_to: none
version: 0.5.2+2

authors:
- Flutter Team <flutter-dev@googlegroups.com>
- Luigi Agosti <luigi@tengio.com>
Expand Down