Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ianko
Copy link
Contributor

@ianko ianko commented Jul 10, 2019

Description

Added a tab to include a live stream demo to the example app. This may help new changes to be tested against live streams as well.

The example app had, and still has, an issue when disposing videos from asset. While trying to investigate the issue, I decided to refactor and clean the example app for a better visibility.

Related Issues

No related issues but, the #1743 is needed in order to play a live stream.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz
Copy link
Contributor

Waiting for #1743 (review) to land before starting reviewing this PR.

@cyanglaz cyanglaz self-assigned this Jul 18, 2019
@cyanglaz
Copy link
Contributor

I am adding this to backlog since #1743 is still in review.

@ianko ianko closed this Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants