[image_picker] image picker memory leak fix on Android

packages/image_picker/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.0+19
+
+* Android: Fix memory leak due not unregistering ActivityLifecycleCallbacks.
+
 ## 0.6.0+18
 
 * Fix video play in example and update video_player plugin dependency.

packages/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerPlugin.java

@@ -80,18 +80,18 @@ public void onActivitySaveInstanceState(Activity activity, Bundle outState) {
           }
 
           @Override
-          public void onActivityDestroyed(Activity activity) {}
+          public void onActivityDestroyed(Activity activity) {
+            if (activity == registrar.activity()) {
+              ((Application) registrar.context()).unregisterActivityLifecycleCallbacks(this);
+            }
+          }
 
           @Override
           public void onActivityStopped(Activity activity) {}
         };
 
-    if (this.registrar != null
-        && this.registrar.activity() != null
-        && this.registrar.activity().getApplication() != null) {
-      this.registrar
-          .activity()
-          .getApplication()
+    if (this.registrar != null) {
+      ((Application) this.registrar.context())
           .registerActivityLifecycleCallbacks(this.activityLifecycleCallbacks);
     }
   }

packages/image_picker/example/android/app/src/test/java/io/flutter/plugins/imagepicker/ImagePickerPluginTest.java

@@ -8,6 +8,7 @@
 import static org.mockito.Mockito.when;
 
 import android.app.Activity;
+import android.app.Application;
 import io.flutter.plugin.common.MethodCall;
 import io.flutter.plugin.common.MethodChannel;
 import io.flutter.plugin.common.PluginRegistry;
@@ -28,6 +29,7 @@ public class ImagePickerPluginTest {
 
   @Mock PluginRegistry.Registrar mockRegistrar;
   @Mock Activity mockActivity;
+  @Mock Application mockApplication;
   @Mock ImagePickerDelegate mockImagePickerDelegate;
   @Mock MethodChannel.Result mockResult;
 
@@ -36,6 +38,7 @@ public class ImagePickerPluginTest {
   @Before
   public void setUp() {
     MockitoAnnotations.initMocks(this);
+    when(mockRegistrar.context()).thenReturn(mockApplication);
 
     plugin = new ImagePickerPlugin(mockRegistrar, mockImagePickerDelegate);
   }

packages/image_picker/pubspec.yaml

@@ -6,7 +6,7 @@ authors:
   - Rhodes Davis Jr. <rody.davis.jr@gmail.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker
 
-version: 0.6.0+18
+version: 0.6.0+19
 
 flutter:
   plugin: