Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] Fixes for iOS auth crash on failed sign-in #1928

Merged
collinjackson merged 10 commits into from
Jul 29, 2019
Merged

[firebase_auth] Fixes for iOS auth crash on failed sign-in #1928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bcbcdca
Fix for iOS auth crash
collinjackson Jul 29, 2019
5ab6df3
Fix test
collinjackson Jul 29, 2019
bbca6b9
Update to new Firebase project
collinjackson Jul 29, 2019
5d1ae45
Avoid signing out before deleting user
collinjackson Jul 29, 2019
738fbbc
Use uuid
collinjackson Jul 29, 2019
35dbbe4
Fix analyzer
collinjackson Jul 29, 2019
7b55275
Bump version
collinjackson Jul 29, 2019
7cfddd5
Update CHANGELOG
collinjackson Jul 29, 2019
655664a
remove unused import
collinjackson Jul 29, 2019
6c22608
Update application identifier to avoid conflict
collinjackson Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/firebase_auth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 0.13.1

* Fixed a crash on iOS when sign-in fails.
* Additional integration testing.
* Updated documentation for `FirebaseUser.delete()` to include error codes.
* Updated Firebase project to match other Flutterfire apps.

## 0.13.0

* **Breaking change**: Replace `FirebaseUserMetadata.creationTimestamp` and
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ android {
}

defaultConfig {
applicationId "io.flutter.plugins.firebaseauthexample"
applicationId "dev.flutter.plugins.firebaseauthexample"
minSdkVersion 16
targetSdkVersion 28
versionCode flutterVersionCode.toInteger()
Expand Down
278 changes: 263 additions & 15 deletions packages/firebase_auth/example/android/app/google-services.json
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,300 @@
{
"project_info": {
"project_number": "466218294969",
"firebase_url": "https://flutter-plugins-auth.firebaseio.com",
"project_id": "flutter-plugins-auth",
"storage_bucket": "flutter-plugins-auth.appspot.com"
"project_number": "159623150305",
"firebase_url": "https://flutter-firebase-plugins.firebaseio.com",
"project_id": "flutter-firebase-plugins",
"storage_bucket": "flutter-firebase-plugins.appspot.com"
},
"client": [
{
"client_info": {
"mobilesdk_app_id": "1:466218294969:android:11e8f037a4a3ec3b",
"mobilesdk_app_id": "1:159623150305:android:2e167f427b396288",
"android_client_info": {
"package_name": "dev.flutter.plugins.firebaseauthexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:236f9daea101f77e",
"android_client_info": {
"package_name": "io.flutter.plugins.firebase.firestoreexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:11e8f037a4a3ec3b",
"android_client_info": {
"package_name": "io.flutter.plugins.firebaseauthexample"
}
},
"oauth_client": [
{
"client_id": "466218294969-ikp8nslafq77v10dkp83f1atvfkacide.apps.googleusercontent.com",
"client_id": "159623150305-6cf91dro1kro30hdlfp3rkod8mldc81c.apps.googleusercontent.com",
"client_type": 1,
"android_info": {
"package_name": "io.flutter.plugins.firebaseauthexample",
"certificate_hash": "f8323ac5fe6e7adc1ddc5612e16b5d04d7f1358b"
"certificate_hash": "4ef1514a34a8edf0f5b3ff7108d3497fa3449f69"
}
},
{
"client_id": "466218294969-t7bmju7plgllvluqpgb1gklfuv56pfr8.apps.googleusercontent.com",
"client_id": "159623150305-pjkkv9ff9tgkmjs7kjalsqv2pp6ltj04.apps.googleusercontent.com",
"client_type": 1,
"android_info": {
"package_name": "io.flutter.plugins.firebaseauthexample",
"certificate_hash": "9ee6a0388f780cf93a852248905d2d3d83d8e50d"
}
},
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyA4il7ZGUO9gi7ErxFspGcaxi0qr9Huifc"
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"analytics_service": {
"status": 1
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:c68d3ad04a4046db",
"android_client_info": {
"package_name": "io.flutter.plugins.firebasedatabaseexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-j5cqghi5snpqptesd2mdjum7o35hiltb.apps.googleusercontent.com",
"client_type": 1,
"android_info": {
"package_name": "io.flutter.plugins.firebasedatabaseexample",
"certificate_hash": "9ee6a0388f780cf93a852248905d2d3d83d8e50d"
}
},
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"status": 2,
"other_platform_oauth_client": [
{
"client_id": "466218294969-t7bmju7plgllvluqpgb1gklfuv56pfr8.apps.googleusercontent.com",
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:620f0e4ca16cbddd",
"android_client_info": {
"package_name": "io.flutter.plugins.firebasemessagingexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-qubsrfqbnrp4vurajv72eujgk164nin0.apps.googleusercontent.com",
"client_type": 1,
"android_info": {
"package_name": "io.flutter.plugins.firebasemessagingexample",
"certificate_hash": "f8323ac5fe6e7adc1ddc5612e16b5d04d7f1358b"
}
},
"ads_service": {
"status": 2
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:ef48439a0cc0263d",
"android_client_info": {
"package_name": "io.flutter.plugins.firebasestorageexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
},
{
"client_info": {
"mobilesdk_app_id": "1:159623150305:android:5e9f1f89e134dc86",
"android_client_info": {
"package_name": "io.flutter.plugins.googlesigninexample"
}
},
"oauth_client": [
{
"client_id": "159623150305-3suu3qq4vs3ki7uaigbtrh2aal1p9ram.apps.googleusercontent.com",
"client_type": 1,
"android_info": {
"package_name": "io.flutter.plugins.googlesigninexample",
"certificate_hash": "f8323ac5fe6e7adc1ddc5612e16b5d04d7f1358b"
}
},
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
}
],
"api_key": [
{
"current_key": "AIzaSyChk3KEG7QYrs4kQPLP1tjJNxBTbfCAdgg"
}
],
"services": {
"appinvite_service": {
"other_platform_oauth_client": [
{
"client_id": "159623150305-q05bbbtsutr02abhips3suj7hujfk4bg.apps.googleusercontent.com",
"client_type": 3
},
{
"client_id": "159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com",
"client_type": 2,
"ios_info": {
"bundle_id": "io.flutter.plugins.firebaseAuthExample"
}
}
]
}
}
}
Expand Down
26 changes: 12 additions & 14 deletions packages/firebase_auth/example/ios/Runner/GoogleService-Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,37 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>AD_UNIT_ID_FOR_BANNER_TEST</key>
<string>ca-app-pub-3940256099942544/2934735716</string>
<key>AD_UNIT_ID_FOR_INTERSTITIAL_TEST</key>
<string>ca-app-pub-3940256099942544/4411468910</string>
<key>CLIENT_ID</key>
<string>466218294969-5mdmh6opkqd87a5m81nm83u4eqd3bvgk.apps.googleusercontent.com</string>
<string>159623150305-h67j0o93bcctblfhde74r7fssmcobamr.apps.googleusercontent.com</string>
<key>REVERSED_CLIENT_ID</key>
<string>com.googleusercontent.apps.466218294969-5mdmh6opkqd87a5m81nm83u4eqd3bvgk</string>
<string>com.googleusercontent.apps.159623150305-h67j0o93bcctblfhde74r7fssmcobamr</string>
<key>ANDROID_CLIENT_ID</key>
<string>159623150305-j5cqghi5snpqptesd2mdjum7o35hiltb.apps.googleusercontent.com</string>
<key>API_KEY</key>
<string>AIzaSyCb0BM8Q9o_gCubuHvsxdxHSgDZaQoZrv0</string>
<string>AIzaSyDyzecVw1zXTpBKwfFHxpl7QyYBhimNhUk</string>
<key>GCM_SENDER_ID</key>
<string>466218294969</string>
<string>159623150305</string>
<key>PLIST_VERSION</key>
<string>1</string>
<key>BUNDLE_ID</key>
<string>io.flutter.plugins.firebaseAuthExample</string>
<key>PROJECT_ID</key>
<string>flutter-plugins-auth</string>
<string>flutter-firebase-plugins</string>
<key>STORAGE_BUCKET</key>
<string>flutter-plugins-auth.appspot.com</string>
<string>flutter-firebase-plugins.appspot.com</string>
<key>IS_ADS_ENABLED</key>
<true></true>
<false></false>
<key>IS_ANALYTICS_ENABLED</key>
<false></false>
<key>IS_APPINVITE_ENABLED</key>
<false></false>
<true></true>
<key>IS_GCM_ENABLED</key>
<true></true>
<key>IS_SIGNIN_ENABLED</key>
<true></true>
<key>GOOGLE_APP_ID</key>
<string>1:466218294969:ios:8d89e1b69d780386</string>
<string>1:159623150305:ios:8d89e1b69d780386</string>
<key>DATABASE_URL</key>
<string>https://flutter-plugins-auth.firebaseio.com</string>
<string>https://flutter-firebase-plugins.firebaseio.com</string>
</dict>
</plist>
1 change: 1 addition & 0 deletions packages/firebase_auth/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ dependencies:
google_sign_in: ^4.0.0
firebase_core: ^0.4.0+8
firebase_dynamic_links: ^0.3.0
uuid: ^2.0.2

dev_dependencies:
flutter_driver:
Expand Down
Loading