Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mogol
Copy link
Contributor

@mogol mogol commented Oct 5, 2017

I updated deprecated firebase_auth api and added suppress warning for firebase_database according flutter/flutter#11154.
Also I renamed FirebaseUser.getToken to FirebaseUser.getIdToken - very breaking changes 🎉

@collinjackson
Copy link
Contributor

lgtm.

can you write a changelog update and update the version in pubspec.yaml to make this mergeable?

I wonder if we should keep getToken as a deprecated method that forwards to getIdToken... I'm fine with it either way, but please make it a 0.x.0 release if you don't want to keep the deprecated version around.

@collinjackson
Copy link
Contributor

collinjackson commented Oct 9, 2017

Oh, also can you make sure that the iOS side is updated with the getToken -> getIdToken change?

@mogol mogol changed the title Fix android warnings Fix flutter_auth warnings Oct 10, 2017
@mit-mit mit-mit requested a review from collinjackson October 11, 2017 11:24
@collinjackson collinjackson changed the title Fix flutter_auth warnings Fix firebase_auth warnings Oct 17, 2017
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collinjackson collinjackson merged commit 5880e46 into flutter:master Oct 17, 2017
collinjackson pushed a commit to collinjackson/plugins that referenced this pull request Oct 17, 2017
* Update firebase_auth deprecated api

* Suppress unchecked warning in firebase_database

* Update example for firebase_auth

* Fix iOS warnings

* Updated pubspec.yaml and CHANGELOG
collinjackson pushed a commit to collinjackson/plugins that referenced this pull request Oct 17, 2017
* Update firebase_auth deprecated api

* Suppress unchecked warning in firebase_database

* Update example for firebase_auth

* Fix iOS warnings

* Updated pubspec.yaml and CHANGELOG
collinjackson pushed a commit to collinjackson/plugins that referenced this pull request Oct 17, 2017
* Update firebase_auth deprecated api

* Suppress unchecked warning in firebase_database

* Update example for firebase_auth

* Fix iOS warnings

* Updated pubspec.yaml and CHANGELOG
@mogol mogol deleted the fix_android_warnings branch October 18, 2017 04:47
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Update firebase_auth deprecated api

* Suppress unchecked warning in firebase_database

* Update example for firebase_auth

* Fix iOS warnings

* Updated pubspec.yaml and CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants