-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher] Adds macOS package with example app #2383
Conversation
amirh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention in the PR description that the example app is a copy of the one for url_launcher and call out what has changed (pubspec.yaml and main.dart?)
I'm not qualified to review the Swift code, so RSLGTM for that part.
| @@ -0,0 +1,58 @@ | |||
| // Copyright 2019 Google LLC | |||
| // | |||
| // Licensed under the Apache License, Version 2.0 (the "License"); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the the standard license header we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, updated
amirh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Any idea when this will be published on pub.dev? I have a desktop sample app in progress that uses |
|
@domesticmouse It is on pub.dev now, but not endorsed yet. You can still use it though. |
|
@franciscojma86 I have no idea what endorsed means, but using |
|
Endorsed means that you would just be able to use |
Description
Adds the macos implementation of the url_launcher plugin.
Tested by adding an example app that runs the e2e tests. This example app is a copy of the url_launcher/example app, with a modified pubspec.yaml that depends on url_launcher from pub, and url_launcher_macos from path. There is also a minor change in main.dart where the last widget is removed since there is no macOS implementation for that method.
The Swift implementation of the plugin was ported from https://github.com/google/flutter-desktop-embedding/tree/master/plugins/flutter_plugins/url_launcher_fde
Related Issues
flutter/flutter#41721
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?