Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] set message handler to nil on detach from engine #2814

Closed
cg021 wants to merge 4 commits into from
Closed

[video_player] set message handler to nil on detach from engine #2814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd468f9
set message handler to nil on detach from engine
cg021 Jun 4, 2020
7a2f263
update version
cg021 Jun 4, 2020
ce76623
Merge branch 'master' into message_handler_crash
cg021 Jun 4, 2020
e7f26e6
Merge branch 'master' into message_handler_crash
Salakar Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.0-nullsafety.9

* iOS: Set message handler to nil on detach fron engine.

## 2.0.0-nullsafety.8

* Migrated from deprecated `defaultBinaryMessenger`.
Expand Down
5 changes: 1 addition & 4 deletions packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,7 @@ - (void)detachFromEngineForRegistrar:(NSObject<FlutterPluginRegistrar>*)registra
[player disposeSansEventChannel];
}
[_players removeAllObjects];
// TODO(57151): This should be commented out when 57151's fix lands on stable.
// This is the correct behavior we never did it in the past and the engine
// doesn't currently support it.
// FLTVideoPlayerApiSetup(registrar.messenger, nil);
FLTVideoPlayerApiSetup(registrar.messenger, nil);
Copy link

@blasten blasten Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like 57151 landed on stable yet

Copy link
Contributor Author

@cg021 cg021 Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So 2759 isn't an appropriate workaround? Since 57151 is on master but not stable, would conditionally setting the messageHandler to nil if not on stable work (i.e. calling flutter channel using NSTask and storing the active channel in an NSString to make this check)?

Copy link

@ldelafuente ldelafuente Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if 57151 is already on stable v1.20.2?

}

- (FLTTextureMessage*)onPlayerSetup:(FLTVideoPlayer*)player
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter
# 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 2.0.0-nullsafety.8
version: 2.0.0-nullsafety.9
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player

flutter:
Expand Down