Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Sep 19, 2020

Description

Older versions of Flutter (still supported by path_provider) need a
'pluginClass: none' to avoid "Invalid plugin specification" errors
when parsing a Dart-only desktop plugin like this one.

Related Issues

Fixes flutter/flutter#66158

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Stable channel still needs a 'pluginClass: none' to avoid
"Invalid plugin specification" errors when parsing a Dart-only desktop
plugin like this one.

Fixes flutter/flutter#66158
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Sep 19, 2020

Adding a bunch of reviewers so whoever can get to it first can approve.

I don't understand how CI on the endorsement PR passed if stable still requires the pluginClass: none workaround.

@stuartmorgan-g
Copy link
Contributor Author

Ah, I think this only happens for people who haven't updated to the current stable. 1.20 shouldn't need this. However, path_provider doesn't require 1.20+ currently, so this should still be added (so that the last version that claims to support older versions isn't broken on those versions).

@cyanglaz
Copy link
Contributor

I think we can just make path_provider to require 1.20+ .

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Sep 19, 2020

I think we can just make path_provider to require 1.20+ .

We could do that later, but if we don't push this first then the last published path_provider that "supports" 1.17 will be broken for 1.17, which is not a good situation to permanently leave the ecosystem in.

@stuartmorgan-g stuartmorgan-g merged commit 8faaed5 into flutter:master Sep 19, 2020
@stuartmorgan-g stuartmorgan-g deleted the path-provider-windows-pluginclass-none branch September 19, 2020 23:06
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
flutter#3052)

Stable channel still needs a 'pluginClass: none' to avoid
"Invalid plugin specification" errors when parsing a Dart-only desktop
plugin like this one.

Fixes flutter/flutter#66158
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
flutter#3052)

Stable channel still needs a 'pluginClass: none' to avoid
"Invalid plugin specification" errors when parsing a Dart-only desktop
plugin like this one.

Fixes flutter/flutter#66158
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
flutter#3052)

Stable channel still needs a 'pluginClass: none' to avoid
"Invalid plugin specification" errors when parsing a Dart-only desktop
plugin like this one.

Fixes flutter/flutter#66158
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

path_provider 1.6.16 causing "Invalid plugin specification" with older versions of Flutter

4 participants