This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider_windows] Add missing method to fake #3068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fake didn't have getFolder, so if a test of something using path_provider_windows (such as shared_preferences_windows) had a fake that overrode getFolder, the analyzer would complain about overriding a non-existent method. This adds it to avoid that analyzer warning. It also fixes a minor issue introduced in the previous change, where folder.dart was accidentally made internal rather than public.
Contributor
Author
|
This should fix the analyzer error on ToT. Since it didn't show up in presubmit I assume the presubmit analyzer is only running on changed plugins? |
Contributor
|
Yes, the presubmit is only run on changed plugins. |
Contributor
Author
|
Landing on red since this fixes the analyzer warning in the postsubmit tests. |
danielroek
pushed a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Oct 1, 2020
The fake didn't have getFolder, so if a test of something using path_provider_windows (such as shared_preferences_windows) had a fake that overrode getFolder, the analyzer would complain about overriding a non-existent method. This adds it to avoid that analyzer warning. It also fixes a minor issue introduced in the previous change, where folder.dart was accidentally made internal rather than public.
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
The fake didn't have getFolder, so if a test of something using path_provider_windows (such as shared_preferences_windows) had a fake that overrode getFolder, the analyzer would complain about overriding a non-existent method. This adds it to avoid that analyzer warning. It also fixes a minor issue introduced in the previous change, where folder.dart was accidentally made internal rather than public.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
The fake didn't have getFolder, so if a test of something using path_provider_windows (such as shared_preferences_windows) had a fake that overrode getFolder, the analyzer would complain about overriding a non-existent method. This adds it to avoid that analyzer warning. It also fixes a minor issue introduced in the previous change, where folder.dart was accidentally made internal rather than public.
mciekurs2
pushed a commit
to mciekurs2/plugins
that referenced
this pull request
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fake didn't have getFolder, so if a test of something using
path_provider_windows (such as shared_preferences_windows) had a fake
that overrode getFolder, the analyzer would complain about overriding a
non-existent method. This adds it to avoid that analyzer warning.
It also fixes a minor issue introduced in the previous change, where
folder.dart was accidentally made internal rather than public.
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?