Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 19, 2021

This mainly splits out the test logic from the messages.dart file.

This is the interface-level change. See #3281 for the complete PR.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I signed the CLA.
  • All existing and new tests are passing.

…rsion.

This mainly splits out the test logic from the messages.dart file.

This is the interface-level change. See flutter#3281 for the complete PR.
@Hixie
Copy link
Contributor Author

Hixie commented Jan 20, 2021

Ok, flutter/packages#265 has an update to pigeon which should fix the failure here.

@Hixie Hixie marked this pull request as draft January 24, 2021 09:21
@Hixie Hixie closed this Feb 4, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Feb 4, 2021

(going to create this afresh)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants