This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[quick_actions] 3/3 Quick actions federated migration #3736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ick_actions_federated_platform_interface
…n' into quick_actions_federated_migration
…actions_federated_migration
…actions_federated_migration
…actions_federated_migration
…actions_federated_migration # Conflicts: # packages/quick_actions/quick_actions/test/quick_actions_test.dart
…actions_federated_migration
# Conflicts: # packages/quick_actions/quick_actions/lib/quick_actions.dart # packages/quick_actions/quick_actions/test/quick_actions_test.dart # packages/quick_actions/quick_actions_platform_interface/LICENSE # packages/quick_actions/quick_actions_platform_interface/lib/method_channel/method_channel_quick_actions.dart # packages/quick_actions/quick_actions_platform_interface/lib/platform_interface/quick_actions_platform.dart # packages/quick_actions/quick_actions_platform_interface/lib/quick_actions_platform_interface.dart # packages/quick_actions/quick_actions_platform_interface/lib/types/quick_action_handler.dart # packages/quick_actions/quick_actions_platform_interface/lib/types/shortcut_item.dart # packages/quick_actions/quick_actions_platform_interface/lib/types/types.dart # packages/quick_actions/quick_actions_platform_interface/test/method_channel_quick_actions_test.dart # packages/quick_actions/quick_actions_platform_interface/test/quick_actions_platform_interface_test.dart
Contributor
mvanbeusekom
left a comment
mvanbeusekom
left a comment
There was a problem hiding this comment.
This PR looks good but have some small questions that I wanted to verify.
packages/quick_actions/quick_actions/test/quick_actions_test.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Updated version, PR now is ready to merge @mvanbeusekom |
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the platform_interface in the quick_actions plugin, finalizing the migration to a federated architecture.
Merge #3734 and #3735 first
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.