Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

  • Adds web support to the drive-examples script comment
  • Enables driving the web integration tests on master
  • Moves web integration tests to the main Dockerfile image since recent Chrome support has been added to the driver

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g requested a review from ditman March 19, 2021 17:59
@google-cla google-cla bot added the cla: yes label Mar 19, 2021
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be running all the tests that are available? I was probably not self-consistent with naming files? :/

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Mar 19, 2021

This doesn't seem to be running all the tests that are available? I was probably not self-consistent with naming files? :/

Capturing from Discord for posterity: the script requires that the driver file end in _test.dart; many web examples use integration_driver.dart instead. That will be fixed separately.

(I think there's a bug in the script where that failure skips more code than its supposed to, as there's logging later on about not being able to find a driver that's not reached.) I misread, that's if it can't figure out what tests to drive. But we should potentially log about name mismatches at this level.)

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 19, 2021
@fluttergithubbot fluttergithubbot merged commit 2068cce into flutter:master Mar 19, 2021
@ditman ditman mentioned this pull request Mar 19, 2021
11 tasks
@stuartmorgan-g stuartmorgan-g deleted the enable-web-integration branch March 19, 2021 21:20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants