Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@JinXJinX
Copy link

@JinXJinX JinXJinX commented Apr 2, 2021

change "https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/..." to "https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase/..."

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz
Copy link
Contributor

cyanglaz commented Apr 2, 2021

@JinXJinX Thanks a lot for the PR. I'm working on a Pr that tries to improve the README of the plugin. #3731

Most of your fixes are addressed in that PR. And I included your fix that wasn't addressed.

I'm going to close this PR as the other PR would land soon and fix the issues here.

@cyanglaz cyanglaz closed this Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants