Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@BeMacized
Copy link
Contributor

This PR adds Android support for the new onUrlChanged event added to the platform interface in #4509.

As this PR contains and depends on the changes made to the platform interface in #4509, this PR will remain in draft state until that PR has been successfully merged and the changes have been published.

Relevant issue:

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios labels Nov 15, 2021
@godofredoc godofredoc changed the base branch from master to main January 6, 2022 22:52
@Hixie
Copy link
Contributor

Hixie commented Feb 23, 2022

@BeMacized are you still interested in working on this PR? Is there anything you need from anyone?

@BeMacized
Copy link
Contributor Author

BeMacized commented Feb 23, 2022

@Hixie We stopped working on this feature due to there being no good way to implement it in the current structure without a breaking change. The changes to the platform interface these PRs depend on that were merged have been reverted. Once #94051 has been resolved I'll be happy to pick it back up again.

@Hixie
Copy link
Contributor

Hixie commented May 3, 2022

@BeMacized should we close this PR in the meantime? We can always refer to the changes in a closed PR. (I ask just because this is one of our oldest PRs and I'm generally trying to clean up our PR queue.)

@BeMacized
Copy link
Contributor Author

@BeMacized should we close this PR in the meantime? We can always refer to the changes in a closed PR. (I ask just because this is one of our oldest PRs and I'm generally trying to clean up our PR queue.)

Yes, I'm closing this. I'll probably be rewriting this feature once 4.0 has been released.

@BeMacized BeMacized closed this May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: webview_flutter Edits files for a webview_flutter plugin platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants