Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter_android] Change default layout direction to ltr #5408

Closed
bparrishMines wants to merge 2 commits into from
Closed

[webview_flutter_android] Change default layout direction to ltr #5408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f6d7c8
change default layout direction
bparrishMines Apr 27, 2022
992ff45
changelog message
bparrishMines Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/webview_flutter/webview_flutter_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.8.6

* Changes default WebView layout direction to `TextDirection.ltr`.

## 2.8.5

* Migrates deprecated `Scaffold.showSnackBar` to `ScaffoldMessenger` in example app.
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_android/lib/webview_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class AndroidWebView implements WebViewPlatform {
},
gestureRecognizers: gestureRecognizers,
layoutDirection:
Directionality.maybeOf(context) ?? TextDirection.rtl,
Directionality.maybeOf(context) ?? TextDirection.ltr,
creationParams:
InstanceManager.instance.getInstanceId(controller.webView),
creationParamsCodec: const StandardMessageCodec(),
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_android/lib/webview_surface_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class SurfaceAndroidWebView extends AndroidWebView {
// WebView content is not affected by the Android view's layout direction,
// we explicitly set it here so that the widget doesn't require an ambient
// directionality.
layoutDirection: TextDirection.rtl,
layoutDirection: TextDirection.ltr,
creationParams:
InstanceManager.instance.getInstanceId(controller.webView),
creationParamsCodec: const StandardMessageCodec(),
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: webview_flutter_android
description: A Flutter plugin that provides a WebView widget on Android.
repository: https://github.com/flutter/plugins/tree/main/packages/webview_flutter/webview_flutter_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22
version: 2.8.5
version: 2.8.6

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down