Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Draft: [camera] Add support for NV21 image format on android (part 2/3) #7022

Closed
acoutts wants to merge 2 commits into from
Closed

Draft: [camera] Add support for NV21 image format on android (part 2/3) #7022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242f986
Adds support for NV21 image format on Android
acoutts Jan 25, 2023
c987dfe
Add test for nv21
acoutts Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.10.3
* Adds support for NV21 streaming format.

## 0.10.2+1

* Updates code for stricter lint checks.
Expand Down
3 changes: 3 additions & 0 deletions packages/camera/camera/lib/src/camera_image.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ ImageFormatGroup _asImageFormatGroup(dynamic rawFormat) {
// android.graphics.ImageFormat.JPEG
case 256:
return ImageFormatGroup.jpeg;
// android.graphics.ImageFormat.NV21
case 17:
return ImageFormatGroup.nv21;
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Flutter plugin for controlling the camera. Supports previewing
Dart.
repository: https://github.com/flutter/plugins/tree/main/packages/camera/camera
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.10.2+1
version: 0.10.3

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -23,7 +23,7 @@ flutter:
dependencies:
camera_android: ^0.10.1
camera_avfoundation: ^0.9.9
camera_platform_interface: ^2.3.2
camera_platform_interface: ^2.4.0
camera_web: ^0.3.1
flutter:
sdk: flutter
Expand Down
24 changes: 24 additions & 0 deletions packages/camera/camera/test/camera_image_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,30 @@ void main() {
expect(cameraImage.format.group, ImageFormatGroup.yuv420);
});

test('$CameraImage has ImageFormatGroup.nv21 for Android', () {
debugDefaultTargetPlatformOverride = TargetPlatform.android;

final CameraImage cameraImage =
CameraImage.fromPlatformData(<dynamic, dynamic>{
'format': 17,
'height': 1,
'width': 4,
'lensAperture': 1.8,
'sensorExposureTime': 9991324,
'sensorSensitivity': 92.0,
'planes': <dynamic>[
<dynamic, dynamic>{
'bytes': Uint8List.fromList(<int>[1, 2, 3, 4]),
'bytesPerPixel': 1,
'bytesPerRow': 4,
'height': 1,
'width': 4
}
]
});
expect(cameraImage.format.group, ImageFormatGroup.nv21);
});

test('$CameraImage has ImageFormatGroup.bgra8888 for iOS', () {
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;

Expand Down