Skip to content

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 26, 2024

Part 1/n flutter/flutter#152374

Pre-launch Checklist

  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I read the [Contributors Guide].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from gmackall July 26, 2024 16:05
@reidbaker reidbaker requested a review from gmackall July 26, 2024 16:40
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@reidbaker reidbaker requested a review from ericwindmill July 26, 2024 16:46
@reidbaker
Copy link
Contributor Author

Running the ci script locally passes for me and @gmackall. Running the tasks involved also do not seem to error. @ericwindmill can you think of anything else I should try to figure out why this is failing only in ci?

@reidbaker
Copy link
Contributor Author

Current theory: The failure might be flutter version dependent. I will check out the previous stable and see if I can reproduce.

@reidbaker
Copy link
Contributor Author

Confirmed that this is broken on 3.22.3 and fixed on master. Also spoke with @ericwindmill out of band who gave the ok to merge anyway since the examples normally need to be updated when there is a new flutter version (which is happening shortly)

@reidbaker reidbaker merged commit f443fa6 into flutter:main Jul 29, 2024
@reidbaker reidbaker deleted the i152374-sample-projects-api-35-part-1 branch July 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants