-
Notifications
You must be signed in to change notification settings - Fork 126
Temporarily disable tiler windows tests #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable tiler windows tests #235
Conversation
|
Can you explain what exactly happened that caused the failure and what will let you reenable the test? |
|
Right now the default font is controlled by whether an env variable is present ( The tests in this repo were passing because I added the env var to the CI configuration but i didn't realize the env var won't be present when flutter/flutter runs these test. I couldn't find a way to set the env variable on windows in a *.test file so I think it's easier/quicker to disable the tests on windows temporarily. Once flutter/engine#40352 lands the failure should go away (since the flutter/test CI is passing) and I'll re-enable those tests. |
yaakovschectman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but probably need to see what Hixie says
|
I'm taking Hixie's response on discord as a LGTM. |
|
auto label is removed for flutter/tests, pr: 235, due to - The status or check suite tests-windows-0 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.