Improve Readme 'if a test is broken' section #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
reviewed
Aug 12, 2025
README.md
Outdated
| so that people have time to migrate (a "soft-breaking" change). | ||
| so that people have time to migrate (a "soft-breaking" change). See Flutter's | ||
| [deprecation policy](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#deprecations) | ||
| for more. |
jtmcdole
previously approved these changes
Aug 12, 2025
Member
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
Thank you for looking into this! Its directionally correct and gives some leeway to developers to say "this will take more than 72 hours" if all parties agree.
Contributor
|
Ok to merge? |
Contributor
Author
|
I totally lost track of this PR. Yes good to merge, though I made a wording change so the tests are running again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the breaking. change process.
@jtmcdole It's been awhile since you filed flutter/flutter#155170, but let me know what you think of these tweaks in relation to your initial problems.