-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix broken link #12874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link #12874
Conversation
Summary of ChangesHello @MoritzMessner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the Flutter documentation by fixing a broken link. The original link, intended to guide users to an example Dart file on GitHub, was malformed and resulted in a 'Not Found' error. By adjusting the URL path to properly reference the file within the repository structure, this change ensures that users can seamlessly access the associated code example, improving the overall user experience and accuracy of the documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully fixes a broken link in the 'Flutter concurrency for Swift developers' documentation. The original link to the async_weather.dart example file was resulting in a 404 error. The change correctly updates the URL to point to the file's location on the main branch, resolving the issue. The fix is correct and well-contained.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 8e6fd39): |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing this. Looks good to me!
Description of what this PR is changing or adding, and why:
Changes
Changed link to show actual file at location https://github.com/flutter/website/blob/main/examples/resources/dart_swift_concurrency/lib/async_weather.dart
Why
Page https://docs.flutter.dev/get-started/flutter-for/dart-swift-concurrency#:~:text=For%20the%20complete%20example%2C%20check%20out%20the%20async_weather%20file%20on%20GitHub
Currently Link points to https://github.com/flutter/website/examples/resources/dart_swift_concurrency/lib/async_weather.dart
and results in a Not Found message.
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.