-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add back(?) introductory video to main docs page #12876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @autorejecttop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an inconsistency on the main Flutter documentation landing page by reintroducing an introductory video. The page's text previously described a video that was no longer present, and this change ensures that the content aligns with the description, thereby improving the user experience for those seeking a visual guide to getting started with Flutter. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR correctly identifies and fixes an issue where an introductory video was missing despite being mentioned in the text. The change is simple and effective. I have one minor suggestion to improve adherence to the project's style guide regarding line length.
| Ready to build beautiful, multiplatform apps from a single codebase? | ||
| This video walks you through the fundamentals of Flutter and shows you how to get started. | ||
|
|
||
| <YouTubeEmbed id="W4JWeQolJsU" title="Build and ship amazing multiplatform iOS and Android apps with one codebase" fullWidth></YouTubeEmbed> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is 138 characters long, which significantly exceeds the 80-character limit for line length that is part of the repository's style guide (as mentioned in the PR checklist). To improve readability and adhere to the 'semantic line breaks' principle, please format the component to span multiple lines.
| <YouTubeEmbed id="W4JWeQolJsU" title="Build and ship amazing multiplatform iOS and Android apps with one codebase" fullWidth></YouTubeEmbed> | |
| <YouTubeEmbed | |
| id="W4JWeQolJsU" | |
| title="Build and ship amazing multiplatform iOS and Android apps with one codebase" | |
| fullWidth> | |
| </YouTubeEmbed> |
References
- The pull request description states adherence to a style guide that uses 'semantic line breaks of 80 characters or fewer'. The added line violates this rule. (link)
Description of what this PR is changing or adding, and why:
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.