-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix unclosed parentheses error on "Create a widget to make buttons" code excerpt #12877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @autorejecttop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but crucial syntax error in a code snippet within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a missing closing brace in a Dart code snippet within the layout tutorial, which was causing a syntax error. While this change effectively resolves the issue for readers of the documentation, it's worth noting that the code snippet appears to be generated from a source file (examples/layout/lakes/step3/lib/main.dart). The underlying problem is likely a misplaced docregion tag in that source file. Modifying the markdown file directly might lead to the fix being overwritten if the documentation is regenerated. For a more permanent solution, the docregion in the source file should be corrected. However, as this PR targets the documentation file, the fix is valid for the problem it solves.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 1027377): |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing this! I appreciate it :D
Description of what this PR is changing or adding, and why:
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.