-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Remove the TextField.canRequestFocus breaking change guide #12893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the TextField.canRequestFocus breaking change guide #12893
Conversation
Summary of ChangesHello @loic-sharma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up the documentation by removing a breaking change guide that is no longer relevant. The guide for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the breaking change guide for TextField.canRequestFocus since the underlying change was reverted. The file deletion and the removal of the link definition in index.md are appropriate. However, a reference to the deleted guide remains in the list of breaking changes in index.md, which will lead to a broken link. I've added a comment to address this oversight.
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once the broken link is fixed.
|
Visit the preview URL for this PR (updated for commit 14b97eb): https://flutter-docs-prod--pr12893-remove-textfield-canrequest-givlvte8.web.app |
|
Fixed! |
|
What do you think about adding a redirect from the removed path to flutter/flutter#149067 or this PR? Just in case there any references to it around. Definitely not required though. Thanks! |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing this and adding the redirect! Looks good to me :D
We made a breaking change to remove
TextField.canRequestFocus(flutter/flutter#130164). However, this caused a google3 failure and was reverted (flutter/flutter#132104).This removes the breaking change guide since we never relanded this change:
Presubmit checklist
of 80 characters or fewer.