Skip to content

Conversation

@loic-sharma
Copy link
Member

We made a breaking change to remove TextField.canRequestFocus (flutter/flutter#130164). However, this caused a google3 failure and was reverted (flutter/flutter#132104).

This removes the breaking change guide since we never relanded this change:

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@loic-sharma loic-sharma requested review from a team and sfshaza2 as code owners January 7, 2026 18:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @loic-sharma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the documentation by removing a breaking change guide that is no longer relevant. The guide for TextField.canRequestFocus was for a change that was introduced, then reverted, and ultimately not relanded. This PR ensures that the documentation accurately reflects the current state of the codebase by eliminating outdated information.

Highlights

  • Documentation Removal: This pull request removes the breaking change guide for TextField.canRequestFocus.
  • Reason for Removal: The original breaking change to remove TextField.canRequestFocus was reverted due to a Google3 failure and was never relanded, making the documentation obsolete.
  • Affected Files: The can-request-focus.md file, which contained the breaking change guide, has been deleted, and the reference to it in index.md has been removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the breaking change guide for TextField.canRequestFocus since the underlying change was reverted. The file deletion and the removal of the link definition in index.md are appropriate. However, a reference to the deleted guide remains in the list of breaking changes in index.md, which will lead to a broken link. I've added a comment to address this oversight.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the broken link is fixed.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jan 7, 2026

Visit the preview URL for this PR (updated for commit 14b97eb):

https://flutter-docs-prod--pr12893-remove-textfield-canrequest-givlvte8.web.app

@loic-sharma
Copy link
Member Author

Fixed!

@parlough
Copy link
Member

parlough commented Jan 7, 2026

What do you think about adding a redirect from the removed path to flutter/flutter#149067 or this PR? Just in case there any references to it around.

Definitely not required though. Thanks!

@loic-sharma
Copy link
Member Author

loic-sharma commented Jan 7, 2026

@parlough That's a good idea, could you double-check 14b97eb matches what you had in mind? This is my first time using a redirect like this :)

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this and adding the redirect! Looks good to me :D

@parlough parlough merged commit e538583 into flutter:main Jan 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants