fix problems with current version of CascadeSelect#8
Merged
mstuder merged 2 commits intofluxapps:mainfrom Feb 2, 2023
ingoj:main
Merged
fix problems with current version of CascadeSelect#8mstuder merged 2 commits intofluxapps:mainfrom ingoj:main
mstuder merged 2 commits intofluxapps:mainfrom
ingoj:main
Conversation
the current versions of CascadeSelect return an array for the column definitions instead of a string. This causes htmlspechialchars to crash, which is called when constructing html fpr the form output. This fix chacks, if the definition is an array and sets the textinput to the name of the column and the default set in "(...)". If the old version of CascadeSelect is used, the fix stay with the old behaviour.
fix CascasdeSelect functionality
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adresses the changes in CascsdeSelect since versien 6-new festures and 7. CascadeSelect returns now an array with the keya "name" and "default" instead of a string. This causes a crash when html for the edit form of an udf-check is created (somewhere down the line htmlspecialchars ist called with an array as parameter).
the fix shoud not create conflicts with the older versions of CascadeSelect, since it only acts if an array si given for the column definition.
Tested with ILIAS 7, current CascadeSeect and current UserDefaults