Add post-render strategy support and conditional defaults#1470
Merged
matheuscscp merged 1 commit intofluxcd:mainfrom Apr 24, 2026
Merged
Add post-render strategy support and conditional defaults#1470matheuscscp merged 1 commit intofluxcd:mainfrom
matheuscscp merged 1 commit intofluxcd:mainfrom
Conversation
matheuscscp
approved these changes
Apr 24, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
Just a nit, otherwise LGTM! 🚀
vocarista
force-pushed
the
enhancement/1469
branch
from
51c8f92 to
7944efd
Compare
Member
|
@vocarista Sorry, I forgot something very important, please add the field docs to |
vocarista
force-pushed
the
enhancement/1469
branch
from
7944efd to
be6543d
Compare
Member
|
Then please squash the commits into one and force-push 🙏 |
vocarista
force-pushed
the
enhancement/1469
branch
2 times, most recently
from
56c06b6 to
697a947
Compare
Contributor
Author
|
Squashed 👾 |
Member
|
@vocarista Can you please open a PR here too? https://github.com/fluxcd/website/blob/main/content/en/flux/components/helm/options.md?plain=1#L67 Then a second PR here (highlighting the breaking change): They have to be two separate PRs because the second one will go live immediately |
Contributor
Author
|
@matheuscscp I've opened the PRs on fluxcd/website |
hiddeco
reviewed
Apr 24, 2026
Signed-off-by: Kumar Piyush <kr.piyush888@gmail.com> Assisted By: Cascade/SWE-1.6:
vocarista
force-pushed
the
enhancement/1469
branch
from
2b42312 to
8f1b711
Compare
matheuscscp
approved these changes
Apr 24, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
LGTM! 🚀
@vocarista Thanks very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1469
combined(Helm 4 breaking change), then in Flux 2.8.6 we fixed the regression (changed the behavior tonohooks). In Flux 2.9 (through this PR) we are changing this default back tocombinedfor honoring the feature gateUseHelm3Defaults, which defaults to the Helm 4 defaults when the gate isfalse, and to the Helm 3 defaults when the gate istrue. We are sustaining our decision to keep aligned with Helm's defaults throughout Flux's and Helm's lives. This commitment implies shipping breaking changes whenever Helm changes default functionality in major versions.The behavior can also be pinned to a specific value directly in the
HelmReleaseobject through the field introduced in this PR.Adds support for Helm's post-render strategies (nohooks, combined, separate) being introduced in Helm 4.2. The new
spec.postRenderStrategyfield allows users to configure how hooks are sent to post-renderers.Changes:
PostRenderStrategyenum with values:nohooks,combined,separatespec.postRenderStrategyfield toHelmReleaseSpectoHelmPostRenderStrategy()mapping function in action packageDefault behavior:
combinedto align with upstream HelmUseHelm3Defaultsfeature gate by switching tonohookswhen enabled