Fix inconsistent code-style raised at security audit#386
Merged
stefanprodan merged 2 commits intofluxcd:mainfrom Dec 22, 2021
pjbgf:audit-followup
Merged
Fix inconsistent code-style raised at security audit#386stefanprodan merged 2 commits intofluxcd:mainfrom pjbgf:audit-followup
stefanprodan merged 2 commits intofluxcd:mainfrom
pjbgf:audit-followup
Conversation
added 2 commits
December 21, 2021 14:03
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
When ExternalEventRecorder is nil, the helm release reference is not used therefore the function can safely return early. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes summary:
ExternalEventRecorderis nil.Relates to fluxcd/pkg#173