[RFC-0010] Introduce object-level workload identity for KMS decryption#1426
Merged
matheuscscp merged 1 commit intomainfrom May 7, 2025
Merged
[RFC-0010] Introduce object-level workload identity for KMS decryption#1426matheuscscp merged 1 commit intomainfrom
matheuscscp merged 1 commit intomainfrom
Conversation
71 tasks
0bd9952 to
75c4de0
Compare
3cdd0e1 to
f7bfb54
Compare
matheuscscp
commented
May 1, 2025
7adfdc7 to
c413d47
Compare
stefanprodan
reviewed
May 3, 2025
776c7eb to
e560ef4
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
stefanprodan
approved these changes
May 7, 2025
Member
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: fluxcd/pkg#919
Part of: fluxcd/flux2#5022
Fixes: #324
This PR also introduces a token cache in kustomize-controller for caching the cloud provider access tokens used for interacting with the respective KMS services. This token cache will report the following metrics:
gotk_token_cache_events_totalTotal number of cache retrieval events for a Gitops Toolkit resource reconciliation.event_type,kind,name,namespace,operation. The values ofevent_typecan becache_missorcache_hit. The value ofoperationisdecrypt_with_<cloud_provider>.gotk_token_cache_requests_totalTotal number of cache requests partioned by success or failure.status. The values ofstatuscan besuccessorfailure.gotk_token_cache_evictions_totalTotal number of cache evictions.gotk_token_cached_itemsTotal number of items in the cache.I tested this PR in the following setups:
EKS:
AKS:
GKE:
.secretRefwith GCP service account JSON key (this is unrelated to workload identity but this code path is changing, so I tested that it still works)