Skip to content

Add fuzz testing for notifiers#306

Merged
stefanprodan merged 1 commit intofluxcd:mainfrom
pjbgf-forks:fuzz
Jan 12, 2022
Merged

Add fuzz testing for notifiers#306
stefanprodan merged 1 commit intofluxcd:mainfrom
pjbgf-forks:fuzz

Conversation

@pjbgf
Copy link
Copy Markdown
Member

@pjbgf pjbgf commented Jan 12, 2022

Following-up from the security audit, I reviewed the initial Fuzz PR and created this PR that supersedes it.

Main changes:

  • Create fuzzers for all notifiers that required no code change to support fuzzing.
  • Structure the fuzz implementation to be closer to what fuzz testing might look like once golang 1.18 built-in fuzz feature is released.
  • Add Makefile target to enable smoke testing fuzzers locally.
  • Add github workflow to test and upload crash results.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Jan 12, 2022
Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @pjbgf

@stefanprodan stefanprodan merged commit 2a728b0 into fluxcd:main Jan 12, 2022
@pjbgf pjbgf deleted the fuzz branch January 12, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants