Add Bitbucket server/Bitbucket Data Center provider for git commit status#639
Add Bitbucket server/Bitbucket Data Center provider for git commit status#639makkes merged 1 commit intofluxcd:mainfrom
Conversation
makkes
left a comment
There was a problem hiding this comment.
Left a couple of comments. My main concern is the pulling-in of that library.
|
@makkes : Thanks for the review and feedback. I have reimplemented the http calls using resty/http library. |
I really don't see the need to pull in any additional library just for a couple of very simple HTTP calls that can just as well be made using |
|
@makkes I have reimplemented the HTTP calls using native net/http library/package. Please let me know for any other feedback. Thx. |
makkes
left a comment
There was a problem hiding this comment.
Looks much better now. I added a couple of additional comments.
makkes
left a comment
There was a problem hiding this comment.
Just some formatting suggestions. Rest lgtm module what darkowlzz asked for.
|
Not sure what happened here but now there's 2 commits and also changes to |
|
Sorry I had messed up my branch a li'l bit. I have reduced the commits by squashing. Does this look fine now? @makkes @darkowlzz |
|
You still have 3 commits in this PR, two of which are basically the same, plus a merge commit. Please remove the merge commit (rebase instead of merge) and make sure this PR shows a single commit in the "Commits" tab. |
Signed-off-by: gdasson <gaurav.dasson@gmail.com>
|
@makkes : Sorry, I was being a bit lazy there 😆. Rebased and squashed down to 1 commit now. Please review. Thanks. |
makkes
left a comment
There was a problem hiding this comment.
Just one last bit, then we're done here. Great job!
| | ------------------------------------------------| ----------------- | | ||
| | [Azure DevOps](#azure-devops) | `azuredevops` | | ||
| | [Bitbucket](#bitbucket) | `bitbucket` | | ||
| | [BitbucketServer](#bitbucket-serverdata-center) | `bitbucketserver` | |
There was a problem hiding this comment.
| | [BitbucketServer](#bitbucket-serverdata-center) | `bitbucketserver` | | |
| | [Bitbucket Server/Data Center](#bitbucket-serverdata-center) | `bitbucketserver` | |
makkes
left a comment
There was a problem hiding this comment.
Oops, selected the wrong item in the previous review.
|
Thanks @gdasson 🏅 |


Atlassian Bitbucket product offers multiple hosting options as documented here
For Flux users that use Bitbucket server or Bitbucket data center solution(mostly enterprises), there is no provider to support posting Git Commit Statuses. This PR provides the git commit status functionality for Bitbucket Server/Data Center.
[ Note: The reason that we can't use existing
bitbucketprovider and the need for a newbitbucketserverprovider stems from the fact that the REST API used by Bitbucket Server/Data Center product is different from Bitbucket Cloud REST API. The existingbitbucketprovider can only support Bitbucket cloud. ]This PR fixes issue: #507