Add MS Adaptive Card payload to msteams Provider#920
Merged
matheuscscp merged 1 commit intomainfrom Sep 12, 2024
Merged
Conversation
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
3 times, most recently
from
f6c1f15 to
573d0a6
Compare
stefanprodan
added
enhancement
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
2 times, most recently
from
1ec21e4 to
418bcfd
Compare
stefanprodan
approved these changes
Sep 7, 2024
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🥇
darkowlzz
reviewed
Sep 9, 2024
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
from
418bcfd to
c524772
Compare
matheuscscp
changed the title
msadaptivecard Providermsteams Provider
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
2 times, most recently
from
8173398 to
5563ce6
Compare
stefanprodan
approved these changes
Sep 11, 2024
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
from
5563ce6 to
0259596
Compare
57 tasks
darkowlzz
reviewed
Sep 11, 2024
Contributor
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
Overall, it looks good to me.
Left a few minor comments.
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
from
0259596 to
eff80ed
Compare
darkowlzz
approved these changes
Sep 12, 2024
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
ms-adaptive-card-provider
branch
from
eff80ed to
e0cf7a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #878
The solution implemented in this PR for addressing the deprecation of the Office 365 Connector is checking the host of the address. If the suffix
.webhook.office.comis present, the controller will keep the old behavior and send the existing payload format. Otherwise, a new payload format for Microsoft Adaptive Card will be sent, which is compatible with the new solution offered by Microsoft Teams: Incoming Webhook with Workflows.