ssa: introduce support for migrating API version#1174
Merged
matheuscscp merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
matheuscscp
added
enhancement
This was referenced Apr 15, 2026
matheuscscp
force-pushed
the
migrate-api-version
branch
2 times, most recently
from
6a3c5e8 to
da60eaa
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
migrate-api-version
branch
from
da60eaa to
18b0e9d
Compare
stefanprodan
approved these changes
Apr 16, 2026
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: fluxcd/flux2#5715
Supersedes: #1131
This PR has tests that reproduce the issue with external-secrets with
MigrateAPIVersionset tofalse, then fixes the issue whenMigrateAPIVersionis set totrue.The new options introduced for the
PatchMigrateToVersionfunction are for scoping the migration down to what Flux controllers actually do: they do not touch subresources and should not touch managed field entries belonging to other managers (the cleanup of kubectl and override managers is responsible for that, incleanupMetadata).